fix: Bundle BankIntegrationTypes DLL without NuGet dependency (v1.1.2)#16
Closed
fix: Bundle BankIntegrationTypes DLL without NuGet dependency (v1.1.2)#16
Conversation
Added dotnet add package command for easy installation *Collaboration by Claude*
Major changes: - Fixed NuGet package to bundle BankIntegrationTypes DLL without listing it as a dependency - Added PrivateAssets="all" to prevent transitive dependency issues - Bumped version to 1.1.2 API improvements: - Introduced modern value object types with validation: - `Iban` (replaces BankAccountV) with IBAN format validation - `Currency` (replaces CurrencyV) with ISO 4217 validation - `BankAccount` (replaces BankAccountWithCurrencyV) combining IBAN and currency - Added static factory methods with Result<T> pattern for all API classes - Renamed `TransferTypeRecordSpecific` to `BankTransferCommonDetails` for clarity - Fixed broken documentation link for payment order status Backward compatibility: - Original types marked as [Obsolete] but still functional - Demo and test projects updated to use new API - Public constructors maintained for TBC API classes Breaking changes: - None - all changes are backward compatible *Collaboration by Claude* Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
The generated NuGet package was listing
AppifySheets.Immutable.BankIntegrationTypesas a dependency even though the DLL was bundled inside the package. This caused restore failures in consuming projects.Solution
Added
PrivateAssets="all"to the ProjectReference to prevent it from being listed as a NuGet dependency while still bundling the DLL.API Improvements
New value object types with validation:
Iban- Validates IBAN format, length, and structureCurrency- Validates ISO 4217 3-letter currency codesBankAccount- Combines IBAN and currency with validationBetter naming:
TransferTypeRecordSpecific→BankTransferCommonDetailsCreateGeorgianmethods that auto-prefixed "GE"Factory methods with Result pattern:
Backward Compatibility
BankAccountV,CurrencyV,BankAccountWithCurrencyV) marked as[Obsolete]Test Plan
Collaboration by Claude